CFn: Stub WaitCondition resource #8332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
These are required for the `run_instances` method, but not valid cloudformation values. We must therefore propagate this information from the properties defaults.
simonrw
force-pushed
the
cfn/cloudformation-waitcondition-resource
branch
from
f4e77b5
to
75a7b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fix for the state fetching of
WaitConditionHandle, and add a stub implementation forWaitConditions.This stub means that anything referencing the wait condition will resolve correctly, but the template deployer won't actually wait until the condition is met. Since we are doing a re-write of CFn anyway, we should factor it into that project.
This PR also includes a bigfix for EC2 instances: the boto3
run_instancesmethod requiresMaxCountandMinCountto be passed, but these are not valid CloudFormation properties.