Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pytest parity markers & marker registration #8767

Merged
merged 9 commits into from Aug 8, 2023

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Jul 28, 2023

Introduce new aws markers @markers.aws.*

    # test has been successfully run against AWS, ideally multiple times
    validated = pytest.mark.aws_validated

    # implies aws_validated. test needs additional setup, configuration or some other steps not included in the test setup itself
    manual_setup_required = pytest.mark.aws_manual_setup_required

    # fails against AWS but should be made runnable against AWS in the future, basically a TODO
    needs_fixing = pytest.mark.aws_needs_fixing

    # only runnable against localstack by design
    only_localstack = pytest.mark.aws_only_localstack

    # it's unknown if the test works (reliably) against AWS or not
    unknown = pytest.mark.aws_unknown

@dominikschubert dominikschubert self-assigned this Jul 28, 2023
@coveralls
Copy link

coveralls commented Jul 28, 2023

Coverage Status

coverage: 81.85% (+0.02%) from 81.832% when pulling 6d2cdc3 on pytest-new-parity-markers into f1ac9eb on master.

@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Aug 2, 2023
@dominikschubert dominikschubert marked this pull request as ready for review August 2, 2023 16:44
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 21m 39s ⏱️
2 037 tests 1 652 ✔️ 385 💤 0
2 038 runs  1 652 ✔️ 386 💤 0

Results for commit b7ebb75a.

♻️ This comment has been updated with latest results.

Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the extra IDE hints for markers 👍

nits:

  • should_be_aws_validated could potentially be mis-understood
  • not sure whether I like the implicit aws_validated of manual setup but it makes it easier to filter ...

localstack/testing/pytest/marking.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@dominikschubert dominikschubert force-pushed the pytest-new-parity-markers branch 2 times, most recently from b7ebb75 to ba6d2d0 Compare August 8, 2023 09:06
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to using the new markers 😄 👍
nice work 🚀 🙏

@dominikschubert dominikschubert merged commit 3704220 into master Aug 8, 2023
25 checks passed
@dominikschubert dominikschubert deleted the pytest-new-parity-markers branch August 8, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants