New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pytest parity markers & marker registration #8767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
added
the
semver: patch
Non-breaking changes which can be included in patch releases
label
Aug 2, 2023
dominikschubert
force-pushed
the
pytest-new-parity-markers
branch
from
August 2, 2023 16:44
df204c9
to
94d58bc
Compare
joe4dev
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the extra IDE hints for markers 👍
nits:
should_be_aws_validated
could potentially be mis-understood- not sure whether I like the implicit
aws_validated
of manual setup but it makes it easier to filter ...
dominikschubert
force-pushed
the
pytest-new-parity-markers
branch
from
August 7, 2023 21:06
eaa36a2
to
af65249
Compare
dominikschubert
requested review from
thrau,
baermat,
bentsku,
viren-nadkarni,
macnev2013,
alexrashed,
pinzon and
simonrw
as code owners
August 7, 2023 21:06
dominikschubert
force-pushed
the
pytest-new-parity-markers
branch
2 times, most recently
from
August 8, 2023 09:06
b7ebb75
to
ba6d2d0
Compare
dominikschubert
force-pushed
the
pytest-new-parity-markers
branch
from
August 8, 2023 09:07
ba6d2d0
to
6d2cdc3
Compare
dfangl
approved these changes
Aug 8, 2023
steffyP
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to using the new markers 😄 👍
nice work 🚀 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new aws markers
@markers.aws.*