This repository was archived by the owner on Mar 23, 2026. It is now read-only.
migrate to new @markers.aws.* markers#8850
Merged
Merged
Conversation
dominikschubert
requested review from
alexrashed,
baermat,
bentsku,
dfangl,
joe4dev,
macnev2013,
pinzon,
simonrw,
steffyP,
thrau and
viren-nadkarni
as code owners
dominikschubert
added
the
semver: patch
dominikschubert
removed request for
alexrashed,
baermat,
bentsku,
dfangl,
joe4dev,
macnev2013,
pinzon,
simonrw,
thrau and
viren-nadkarni
steffyP
approved these changes
Aug 8, 2023
Member
steffyP
left a comment
steffyP
left a comment
There was a problem hiding this comment.
Nice, the first new markers in action 😄
| from localstack.utils.strings import short_uid | ||
|
|
||
| pytestmark = [markers.parity.only_localstack] | ||
| pytestmark = [markers.aws.only_localstack] |
Member
There was a problem hiding this comment.
i think for the next iteration we should try to get rid of this module-level markers as well :)
|
|
||
| @markers.parity.only_localstack | ||
| @markers.parity.aws_validated | ||
| @markers.aws.only_localstack |
Member
There was a problem hiding this comment.
that's interesting: it seems to be both: only_localstack + aws.validated 😅
as it's a snapshot test, i guess the only_localstack can be removed some time :)
Member
Author
There was a problem hiding this comment.
yeah I'll soon be enforcing that a test can only ave one of the @markers.aws.* markers. Basically any test in tests/aws/ has to have exactly one marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We've recently introduced new pytest markers in #8767 and we want to now move towards using these new markers.
Changes
Refactors all
aws_validatedandonly_localstackmarkers to@markers.aws.*Future work
A follow-up PR will add
@markers.aws.unknownmarkers to all unmarked tests.