implement S3 native PublicAccessBlock and ObjectOwnership #8886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
changed the base branch from
master
to
s3-native-fix-and-bucket-payment
bentsku
added
aws:s3
bentsku
force-pushed
the
s3-native-access-block-ownership
branch
from
dd4a95b
to
72738a3
Compare
bentsku
force-pushed
the
s3-native-fix-and-bucket-payment
branch
3 times, most recently
from
28989a6
to
d17f3be
Compare
bentsku
force-pushed
the
s3-native-access-block-ownership
branch
from
72738a3
to
ea55b5a
Compare
bentsku
force-pushed
the
s3-native-fix-and-bucket-payment
branch
from
d17f3be
to
619d669
Compare
bentsku
force-pushed
the
s3-native-access-block-ownership
branch
from
ea55b5a
to
8f4f6cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement Bucket API operations, those are currently only mocked and do not influence S3 behaviour. ObjectOwnership should have some impact, as it should prevent some ACLs to be set on Object, like in AWS. PublicAccessBlock cannot really be enforced, as we do not have the concept of public/anonymous access to S3 (credentials are always being set). It also has some logic tied to
s3control, where the settings would be the most restrictive between the bucket PublicAccessBlock and the owner ones. As it's only mocked, we currently do not implemented this.Changes
Implement the following API operations:
GetBucketOwnershipControlsPutBucketOwnershipControlsDeleteBucketOwnershipControlsGetPublicAccessBlockPutPublicAccessBlockDeletePublicAccessBlockAnd the validation snapshot tests that go with it.