This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Merged
Conversation
b6c5246 to
2c9e482
Compare
9a3988c to
596f6df
Compare
Contributor
Author
|
Update: around 60 tests are still failing on 23/09/10, mostly related to pre-signed URLs |
a265619 to
d758d94
Compare
Contributor
Author
|
Update: only 1 or 2 tests are failing:
edit: this was due to some wrong logic in the storage layer, this should now be fixed 🎉 |
5ca1c2d to
d6c9525
Compare
8bde1ac to
3545e7e
Compare
19c8422 to
6ff5c4c
Compare
ef5eb95 to
3fcbb2a
Compare
6dd6b1b to
7b9e2b4
Compare
7defab6 to
8d09b49
Compare
7b9e2b4 to
e77b647
Compare
18da430 to
a966604
Compare
fb5da7d to
99278b3
Compare
a966604 to
b6a5649
Compare
alexrashed
approved these changes
Nov 6, 2023
Member
alexrashed
left a comment
There was a problem hiding this comment.
Nice! Really great to see the native provider becoming the default! 🚀 🧹
localstack-bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR will make the new s3 v3 provider default for the new 3.0 release.
Changes
Make the new provider default, create a new
legacy_v2provider for S3 for us to advertise instead ofv2orasfwhich don't communicate well the fact that it's the previous implementation.Remove checks for
NATIVE_PROVIDERas it's now default, and invert the checks.Add a warning if people are still using
v2.Updated the CI job to test legacy v2, we can keep until the release of
3.1to ensure stability and visibility into moto changes.Note: sorry for the changes once again in the tests conditions, I missed this change in the removal of the legacy code.
Contained PRs (30):
Incoming PRs: