implement S3 native pre-signed POST (PostObject) #8907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
bentsku
force-pushed
the
s3-native-post-object
branch
from
960d45f
to
3ed03e0
Compare
thrau
approved these changes
Aug 16, 2023
bentsku
force-pushed
the
s3-native-acl
branch
2 times, most recently
from
c2b8852
to
2f79dec
Compare
bentsku
force-pushed
the
s3-native-post-object
branch
from
3ed03e0
to
153493c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implementing the missing PostObject operation, which is needed for pre-signed POST requests.
Changes
PostObjectis a bit of a weird operation in itself because everything is in a form, and the parser doesn't handle this kind of request right now, and maybe it shouldn't just for one operation. So most of the "parsing" is done directly in the provider method. I've added a bit more features than moto, as we now handle encryption parameters, tagging, and more response fields.