fix S3 v3 HeadObject with checksum #9297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #6659 (comment), calling
HeadObjecton a an object withChecksumMode=ENABLEDwill raise an exception. I totally missed it when copy/pasting the implementation fromGetObject, because of a#noqaput there because of typing (dynamic key value inside the*Responseobject).Changes
Fixed the line to use the object checksum instead of a non-existent variable.
I've also removed all the
noqafrom the provider because some type warnings are better than fully failing that this.