Remove localstack client dependency #9368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
localstack-client
package used to define some of the core internals of LocalStack, particularly the service endpoints. This is a leftover from before we handled all requests through the single edge port 4566. Now that we don't use per-service ports, we have no need for thelocalstack-client
package.Changes
This PR has been open for a while, where previous changes removed the usage from within the Python code base itself. However, after rebasing recently I found no usages of the package in the code itself. The only change remaining is to stop installing the package. It is currently in the list of dependencies to support usage in -ext (arguably the dependency should have been moved there at some point, but it's not important), so we can remove it from this repo.