fix inter services IAM for S3 Notifications #9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:iam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up from #9370, to add proper region support to S3 notifications, I've added the region to the client's creation, but also added the account id as done in #9023 for sending notifications. I'll trigger an -ext run on this PR and link it here. Sorry!
https://github.com/localstack/localstack-ext/actions/runs/6582528350
https://github.com/localstack/localstack-ext/runs/17885245621
S3 notifications are fixed, only appsync remains
Changes
Remove the account id from the client creation to trigger test event.
Also removed the account id from the client's creation to send to SQS/Lambda/SNS. But this might create issue again with multi account? \cc @viren-nadkarni why was this change made in the first place?
I believe that SNS/Lambda/SQS will retrieve the account id from the ARN passed and not from the credentials of the request to then retrieve the resource in their store, is that right?