This repository was archived by the owner on Mar 23, 2026. It is now read-only.
EventBridge: Multi-accounts compatibility#9023
Merged
Merged
Conversation
viren-nadkarni
added
the
semver: minor
This reverts commit f01528a.
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 11m 55s ⏱️ - 43m 41s Results for commit f62aa28. ± Comparison against base commit fa10d1d. This pull request removes 3 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
viren-nadkarni
requested review from
alexrashed,
baermat,
bentsku,
calvernaz,
dfangl,
dominikschubert,
joe4dev,
macnev2013 and
thrau
as code owners
viren-nadkarni
removed request for
alexrashed,
bentsku,
calvernaz,
joe4dev,
macnev2013 and
thrau
viren-nadkarni
force-pushed
the
eventbridge-multi-accounts
branch
from
d13f419 to
3b3ad9f
Compare
viren-nadkarni
force-pushed
the
eventbridge-multi-accounts
branch
from
3b3ad9f to
d3678d3
Compare
viren-nadkarni
commented
Sep 12, 2023
| enabled_api_keys = [] | ||
| if not client: | ||
| client = connect_to(region_name=region_name).apigateway | ||
| client = connect_to().apigateway |
Member
Author
There was a problem hiding this comment.
Temporary change until the client arg is made mandatory
viren-nadkarni
commented
Sep 12, 2023
|
|
||
| return _get_arn | ||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
There was a fixture and a utility (localstack.utils.aws.arns.sqs_queue_arn) with the same name that caused confusion and silent overwrite in some instances. The fixture is removed in favour of the utility.
viren-nadkarni
force-pushed
the
eventbridge-multi-accounts
branch
from
2321cc2 to
86d2b5d
Compare
viren-nadkarni
requested review from
MEPalma,
pinzon,
silv-io and
simonrw
as code owners
dominikschubert
approved these changes
Sep 12, 2023
Member
dominikschubert
left a comment
dominikschubert
left a comment
There was a problem hiding this comment.
LGTM, though there"s a lot more than eventbridge in there :D
thanks for tacking this
Comment on lines
+1299
to
+1301
| @pytest.mark.parametrize("strategy", ["domain", "path"]) | ||
| def test_trigger_event_on_ssm_change(self, monkeypatch, aws_client, clean_up, strategy): | ||
| monkeypatch.setattr(config, "SQS_ENDPOINT_STRATEGY", strategy) |
viren-nadkarni
force-pushed
the
eventbridge-multi-accounts
branch
from
8be0c83 to
46c55e7
Compare
Member
Author
|
The fixture has been restored due to concerns from Daniel that it will hinder the ability to run all tests against AWS. It's been renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using values other than
000000000000for account ID orus-east-1for region, EventBridge would still create the consequent resources in this accounts and region.Changes
get_account_id()andget_region()helpers