fix s3 v3 EncodingType in List* operations #9429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
This was referenced Oct 22, 2023
macnev2013
reviewed
Oct 23, 2023
macnev2013
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #9427, we would return
EncodingTypeeven when not specified. It was because of a wrong assumption on my side because boto always adds the parameter, which seemed like it was default.Changes
Corrected the behaviour and validated it by using an HTTP client instead of boto and manually asserting the absence of the
EncodingTypefield and the change in behaviour.Also sneaked a tiny test for
DeleteBucketPolicyvalidating a question here: #9404 (comment)fixes #9427