-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing a --host option to allow using (n) subdomains #50
Conversation
i made docker file for this pr. |
im testings and works +1 |
is anyone still working on this PR ? |
the PR works! |
Looks like we're having a conflict here. |
@manuelbieh I think docs need to be added. @defunctzombie will you merge an publish new version with docker image please? |
@manuelbieh, please, resolve so simple conflict on empty lines, otherwise this PR will stuck for another year 🤦♂️ |
@manuelbieh, you are 🚀. Resolved in 5 minutes 👍 |
I usually respond within 5 minutes or never 😁😉 |
BTW I've made alternative implementation of this feature, some may check if needed #65 |
When is this feature going to be integrated? |
Using this PR. I now have a new error when trying to get a tunnel
node version : 6.9.1 |
Closing in favor of #65. Will evaluate that PR as a potential enhancement. |
Fixes #31
Example usage:
$ node bin/server --port 1234 --host multi.levels.deep.mydomain.com
Client:
Also allows usage of sub-sub[-sub[...]] domains:
$ node bin/server --port 1234 --host levels.deep.mydomain.com
Client:
Possible usecase (my particular case): debugging of "customer specific subdomain webapps" on a developer machine running localtunnel (exampleproject.manuel.tunnelserver.company.org). tunnelserver.company.org would be the tunnel server's url and
exampleproject.manuel
a custom subdomain pointing to a very specific project on my machine.Imagine you needed access to a specific team on Slack (teamname.slack.com) on a developer's local machine (teamname.manuelsmachine.slack.com) from outside via localtunnel on a company's dev domain (teamname.manuelsmachine.localtunnel.slack.com). It would be as simple as
node bin/server --host localtunnel.slack.com
andlt --port 80 --host http://localtunnel.slack.com --subdomain teamname.manuelsmachine
(I'm not working for Slack, just using it as example since everybody knows the pattern behind Slack's URLs)