Fail msetnx if passed arguments are empty (#152)

Resolves #151
locationlabs · Sep 5, 2018 · fd4e311 · fd4e311
1 parent 99fc1af
commit fd4e311
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/mockredis/client.py b/mockredis/client.py
@@ -434,6 +434,9 @@ def msetnx(self, *args, **kwargs):
         else:
             mapping = kwargs
 
+        if len(mapping) == 0:
+            raise ResponseError("wrong number of arguments for 'msetnx' command")
+
         for key in mapping.keys():
             if self._encode(key) in self.redis:
                 return False

diff --git a/mockredis/tests/test_string.py b/mockredis/tests/test_string.py
@@ -228,6 +228,10 @@ def test_msetnx(self):
         ok_(not self.redis.msetnx(**{"key3": "world", "key2": "there"}))
         eq_([b"hello", b"there", None], self.redis.mget("key1", "key2", "key3"))
 
+    @raises_response_error
+    def test_msetnx_empty_args(self):
+        self.redis.msetnx({})
+
     def test_psetex(self):
         test_cases = [200, timedelta(milliseconds=250)]
         for case in test_cases: