-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_point_values result incorrect for SPACETIME layer #619
Comments
@jdries Thank you for bringing this to our attention! You're correct, the |
…values be returned from spacetime layers Cleaned up code slightly by passing the times back as strings Updated the documentation to reflect the changes in return type for get_point_values
…values be returned from spacetime layers Cleaned up code slightly by passing the times back as strings Updated the documentation to reflect the changes in return type for get_point_values Put datetime back in layer.py for now
…values be returned from spacetime layers Cleaned up code slightly by passing the times back as strings Updated the documentation to reflect the changes in return type for get_point_values Put datetime back in layer.py for now Fixed import order
Thanks for the fast response, great help!
(I'm using GeoPySpark as a backend in a new project:
http://openeo.org/ !)
Jeroen Dries
TAP - Centre for Remote Sensing and Earth Observation Processes
VITO NV | Boeretang 200 | 2400 Mol
tel. +32 14 33 55 11 | jeroen.dries@vito.be<https://outlook.vito.be/OWA/redir.aspx?C=bkbvq29Z1EO1hvVK0QJMbACOitzQ7c8Ip7CWFVkhZV75OTezDjCIkdDzkCq1rif2MTOFHY6bxtg.&URL=mailto%3avoornaam.naam%40vito.be>
…________________________________
Van: Jacob Bouffard <notifications@github.com>
Verzonden: vrijdag 19 januari 2018 17:27
Aan: locationtech-labs/geopyspark
CC: Dries Jeroen; Mention
Onderwerp: Re: [locationtech-labs/geopyspark] get_point_values result incorrect for SPACETIME layer (#619)
@jdries<https://github.com/jdries> There's now a PR up that fixes this issue: #620<#620> It will most likely be merged sometime early next week.
-
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#619 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFqXyNlZmkxJ5JxJZn6IjO_N681Ed_Piks5tMMKMgaJpZM4RjYhH>.
Indien u VITO Mol bezoekt, hou aub er dan rekening mee dat de hoofdingang voortaan enkel bereikbaar is vanuit de richting Dessel-Retie, niet vanuit richting Mol, zie vito.be/route.<http://www.vito.be/route>
If you plan to visit VITO at Mol, then please note that the main entrance can only be reached coming from Dessel-Retie and no longer coming from Mol, see vito.be/en/contact/locations.<http://www.vito.be/en/contact/locations>
VITO Disclaimer: http://www.vito.be/e-maildisclaimer
|
@jdries This looks like a really exciting project. Great you are using GeoPySpark. We are definitely happy to help. There will be three people that work on GeoTrellis / GeoPySpark in Bonn in March for the OS Code Sprint. Will you or anyone from your team be attending? It could be a great opportunity to discuss in person. |
I use the get_point_values method on a TiledRasterLayer of type SPACETIME. The layer has tiles at multiple time instants, so I'm in this case:
If ``points`` is a ``list`` and the ``layer_type`` is ``SPACETIME``: [(shapely.geometry.Point, datetime.datetime, [float])]
In my result, I never get tuples for only one date. I think the error is in:
geopyspark.geotrellis.TemporalTiledRasterLayer._getPointValues
as there a toMap method is used to return a Map[Long, (Long, Array[Double])] .
I also had a look at the unit test, and it only seems to test cases where there is only one time instant in the source data.
The text was updated successfully, but these errors were encountered: