Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset table cache when delete catalog. #2665

Closed
wants to merge 6 commits into from

Conversation

Sheldon-Hsu
Copy link
Contributor

A new PR for #2660
This change making tableExists into a var makes it not thread safe anymore.

Signed-off-by: xxxxs Susheldon@users.noreply.github.com

Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
xxxxs and others added 3 commits December 17, 2020 15:49
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
@Sheldon-Hsu
Copy link
Contributor Author

@elahrvivaz Hi Emilio , I have a question, why does build-and-test always fail in my PR? I have not modified the content of the test code.

Copy link
Contributor

@elahrvivaz elahrvivaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working through things!

Copy link
Contributor

@elahrvivaz elahrvivaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, the build is failing due to one of the metadata impls not implementing the new method you added:

/home/runner/work/geomesa/geomesa/geomesa-kafka/geomesa-kafka-confluent/src/main/scala/org/locationtech/geomesa/kafka/confluent/ConfluentMetadata.scala:24: class ConfluentMetadata needs to be abstract, since method resetCache in trait GeoMesaMetadata of type ()Unit is not defined
Error:  class ConfluentMetadata(val schemaRegistry: SchemaRegistryClient) extends GeoMesaMetadata[String] with LazyLogging {

(the error about needing to be abstract is wrong, you just need to add an impl for the resetCache() method)

@Sheldon-Hsu
Copy link
Contributor Author

oh, the build is failing due to one of the metadata impls not implementing the new method you added:

/home/runner/work/geomesa/geomesa/geomesa-kafka/geomesa-kafka-confluent/src/main/scala/org/locationtech/geomesa/kafka/confluent/ConfluentMetadata.scala:24: class ConfluentMetadata needs to be abstract, since method resetCache in trait GeoMesaMetadata of type ()Unit is not defined
Error:  class ConfluentMetadata(val schemaRegistry: SchemaRegistryClient) extends GeoMesaMetadata[String] with LazyLogging {

(the error about needing to be abstract is wrong, you just need to add an impl for the resetCache() method)

Sorry, my project only includes geomesa-hbase and related content. I have modified to rewrite the build with a complete project, and now it can be successful.

Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
@elahrvivaz
Copy link
Contributor

merged as 9daf410

@elahrvivaz elahrvivaz closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants