-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reset table cache when delete catalog. #2665
Conversation
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
geomesa-index-api/src/main/scala/org/locationtech/geomesa/index/geotools/GeoMesaDataStore.scala
Outdated
Show resolved
Hide resolved
geomesa-index-api/src/main/scala/org/locationtech/geomesa/index/geotools/GeoMesaDataStore.scala
Outdated
Show resolved
Hide resolved
geomesa-index-api/src/main/scala/org/locationtech/geomesa/index/geotools/GeoMesaDataStore.scala
Outdated
Show resolved
Hide resolved
geomesa-index-api/src/main/scala/org/locationtech/geomesa/index/geotools/GeoMesaDataStore.scala
Outdated
Show resolved
Hide resolved
...sa-index-api/src/main/scala/org/locationtech/geomesa/index/metadata/TableBasedMetadata.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
...sa-index-api/src/main/scala/org/locationtech/geomesa/index/metadata/TableBasedMetadata.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
@elahrvivaz Hi Emilio , I have a question, why does build-and-test always fail in my PR? I have not modified the content of the test code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working through things!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, the build is failing due to one of the metadata impls not implementing the new method you added:
/home/runner/work/geomesa/geomesa/geomesa-kafka/geomesa-kafka-confluent/src/main/scala/org/locationtech/geomesa/kafka/confluent/ConfluentMetadata.scala:24: class ConfluentMetadata needs to be abstract, since method resetCache in trait GeoMesaMetadata of type ()Unit is not defined
Error: class ConfluentMetadata(val schemaRegistry: SchemaRegistryClient) extends GeoMesaMetadata[String] with LazyLogging {
(the error about needing to be abstract is wrong, you just need to add an impl for the resetCache() method)
Sorry, my project only includes geomesa-hbase and related content. I have modified to rewrite the build with a complete project, and now it can be successful. |
Signed-off-by: xxxxs <Susheldon@users.noreply.github.com>
merged as 9daf410 |
A new PR for #2660
This change making tableExists into a var makes it not thread safe anymore.
Signed-off-by: xxxxs Susheldon@users.noreply.github.com