AvroSerialization Now Uses Proj4Strings in the Encoding/Decoding of ProjectedExtents and TemproalProjectedExtents #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Proj4 strings instead of EPSG codes
|
This change is fine and it certainly allows you to support more projections. One thing that's convenient about EPSG code is that it's less ambitious and much more compact. Do you think it makes sense to define the codec to store the EPSG code if its available or proj4 string otherwise? |
|
I think it does. I'll update this PR so that the serializer can use either value. |
|
Superseded by: #2034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a previously merged in change, #1971 , so that the
Proj4StringofProjectedExtentandTemproalProjectedExtentwill be encoded/decoded instead of their EPSG code.