Estimate partitions number basing on a desired partition size #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
feature/s3geotiffrdd-opt
branch
2 times, most recently
from
26b5618
to
c7a012c
Compare
…sired partition size in bytes. Signed-off-by: Grisha Pomadchin <gr.pomadchin@gmail.com>
pomadchin
force-pushed
the
feature/s3geotiffrdd-opt
branch
from
c7a012c
to
a44f158
Compare
|
To answer the question: The default behavior on principle should "just work" as much as possible. That is not the case currently, we pretty much require partition and window size tuning before we can expect good performance. So in such a case the defaults can be changed to provide the correct behavior. |
|
Fixed in #2296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also introduces a new default
S3GeoTiffRDDbehaviour.The question is: should we change the default reader behaviour? Or it's still should be an optional feature.