New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sum resampling method to raster.resampling #2326

Merged
merged 3 commits into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@Charmatzis
Contributor

Charmatzis commented Aug 10, 2017

Does what it says: Sum method has been added for resampling.

Now the aggregate resampling methods are:

  1. Median
  2. Max
  3. Min
  4. Sum
@pomadchin

This comment has been minimized.

Member

pomadchin commented Aug 10, 2017

Thanks @Charmatzis! Can you sign your commits?
git commit --amend -s && git push origin -f master

@Charmatzis Charmatzis force-pushed the Charmatzis:master branch from b27e07d to 8a69298 Aug 11, 2017

Added Sum resampling method
Signed-off-by: Christos <xr_xarmatzis@outlook.com>

@Charmatzis Charmatzis force-pushed the Charmatzis:master branch from 8a69298 to 3304544 Aug 23, 2017

Merge remote-tracking branch 'refs/remotes/locationtech/master'
Signed-off-by: Christos <xr_xarmatzis@outlook.com>

@Charmatzis Charmatzis force-pushed the Charmatzis:master branch from a8285c8 to 36856a3 Aug 23, 2017

@echeipesh

This comment has been minimized.

Contributor

echeipesh commented Sep 7, 2017

@Charmatzis actually just adding Signed-off-by: Christos Charmatzis <xr_xarmatzis@outlook.com> to the bottom of the PR is sufficient to make ip-validation happy. I know this is silly, but if you don't mind.

@pomadchin

This comment has been minimized.

Member

pomadchin commented Sep 7, 2017

@Charmatzis try to rebase on master, probably IP issue with noreply@github.com would go:

git commit rebase -i upstream/master && git push origin -f master

@echeipesh there is a valid sign-off-by footer, looks like IP checker result is that email has no valid ECAs. Can you check it manually?

@echeipesh

This comment has been minimized.

Contributor

echeipesh commented Sep 28, 2017

screen shot 2017-09-28 at 4 36 19 pm

Looks good, blaming ip-validation bot glitch.

@echeipesh echeipesh merged commit 4c93452 into locationtech:master Sep 28, 2017

1 of 2 checks passed

ip-validation The pull request did not pass Eclipse validation. The following users do not have valid ECAs: noreply@github.com, xr_xarmatzis@outlook.c...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment