Remove explicit unused Scaffeine dependency from projects #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
fix/proj4-deps-cleanup
branch
from
60a4391
to
5e6d234
Compare
pomadchin
commented
Dec 9, 2020
| @@ -127,7 +127,7 @@ lazy val `cassandra-spark` = project | |||
| lazy val hbase = project | |||
| .dependsOn(store) | |||
| .settings(Settings.hbase) | |||
| .settings(projectDependencies := { Seq((layer / projectID).value.exclude("com.google.protobuf", "protobuf-java")) }) | |||
| .settings(projectDependencies := { Seq((store / projectID).value.exclude("com.google.protobuf", "protobuf-java")) }) | |||
There was a problem hiding this comment.
That worked only accidentially!
pomadchin
changed the title
pomadchin
force-pushed
the
fix/proj4-deps-cleanup
branch
from
2d87cc7
to
e61c102
Compare
CloudNiner
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We need to review dependecnies usage in the project modules. A great example of an unused dependency is SCaffeine which is definitely not used in
geotrellis-proj4.Checklist