Initial creation - map/reduce store copy command #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfecher
requested changes
Apr 18, 2017
| } | ||
| catch (IOException e) { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
| } | ||
| catch (IOException e) { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
| } | ||
| catch (IOException e) { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
| } | ||
| catch (IOException e) { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
| @@ -101,6 +101,7 @@ public void write( | |||
| rowMutation.getMutations()); | |||
| } | |||
| catch (final IOException e) { | |||
| System.out.println("KAM: Unable to write mutation."); | |||
| @@ -147,6 +147,7 @@ | |||
| writableAdapter.getAdapterId().getString()); | |||
| } | |||
| catch (final IOException e) { | |||
| System.out.println("KAM: Writing to table failed."); | |||
| throws Exception { | ||
| // Load some test data | ||
| LOGGER.warn("Loading input data..."); | ||
| TestUtils.testLocalIngest( |
There was a problem hiding this comment.
we may want to pick a smaller test case for speedy tests
| if (writer == null) { | ||
| return Collections.emptyList(); | ||
| throw new IOException( | ||
| "Null writer - empty list returned"); |
There was a problem hiding this comment.
does it return an empty list? ... may want to remove the commented out line too
| } | ||
| entryInfo = getEntryInfo( | ||
| entry, | ||
| fieldVisibilityWriter); | ||
| if (entryInfo == null) { | ||
| return Collections.emptyList(); | ||
| throw new IOException( |
1 similar comment
rfecher
approved these changes
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.