Avoid using ArrayList in MonotoneChain builders #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
pramsey
added a commit
to pramsey/geos
that referenced
this pull request
Sep 4, 2019
MonotoneChainBuilder can be refactored to avoid using an array of indexes completely, by constructing MonotoneChain objects as they determined.
strk
pushed a commit
to libgeos/geos
that referenced
this pull request
Sep 4, 2019
an array of indexes completely, by constructing MonotoneChain objects as they determined. locationtech/jts#467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #463, currently
MonotoneChainconstruction uses a temporaryArrayListto accumulate int index values. This causes unnecessary object allocation, and may be slower (although this is not certain).The use of
ArrayListis avoided in two ways:MonotoneChainBuildercan be refactored to avoid using a array of indexes completely, by constructingMonotoneChainobjects as they determinedMonotoneChainIndexerthe return of anint[]is required, but it is changed to use a new utility classIntArrayList. This class uses primitiveintvalues, and so should have less memory pressure than anArrayListofInteger