Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude junit compile dependency from json-simple #855

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Exclude junit compile dependency from json-simple #855

merged 1 commit into from
Mar 31, 2022

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Mar 26, 2022

JUnit should be a test dependency only. Projects using jts-io-common also inherits from this (outdated) dependency.
See fangyidong/json-simple#91

@murdos
Exclude junit compile dependency from json-simple
7901748 
JUnit should be a test dependency only. Projects using `jts-io-common` also inherits from this (outdated) dependency.
See fangyidong/json-simple#91
jodygarnett
jodygarnett approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want a transitive dependency on junit, json-simple library probably just messed up.

@dr-jts dr-jts merged commit ed1e491 into locationtech:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodygarnett jodygarnett jodygarnett approved these changes

@mprins mprins mprins approved these changes

Assignees
No one assigned
Labels
build type-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@murdos @jodygarnett @mprins @dr-jts