Fix OffsetCurve to use a minimum QuadrantSegs value #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-jts
changed the title
pramsey
added a commit
to pramsey/geos
that referenced
this pull request
May 26, 2023
References qgis/QGIS#53165 References libgeos#897
pramsey
added a commit
to libgeos/geos
that referenced
this pull request
May 29, 2023
* References qgis/QGIS#53165 * References #897
pramsey
added a commit
to libgeos/geos
that referenced
this pull request
May 29, 2023
* References qgis/QGIS#53165 * References #897
pramsey
added a commit
to libgeos/geos
that referenced
this pull request
May 29, 2023
* References qgis/QGIS#53165 * References #897
pramsey
added a commit
to libgeos/geos
that referenced
this pull request
May 29, 2023
This reverts commit 27d4d95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce a minimum value for the Offset Curve Quadrant Segments (a value of 8 works well). This fixes an issue with offset curve artifacts appearing when very small QuadSeg values are used. This is due to the need to have a relatively circular end cap in the associated buffer polygon.
At some future point it might be possible to enforce the minimum QS value for just the end caps, since using a small at joins should not cause a problem.
Fixes #980
See also libgeos/geos#917