revert emf model rebuild changes for layers view #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return layerItemProvider; | ||
| return new LayerItemProvider(this); |
There was a problem hiding this comment.
This is an interesting change - I guess it makes a unique provider each time (rather than a single one). This is only necessary if the provider is now statefull - is that now the case?
jodygarnett
added a commit
that referenced
this pull request
Feb 12, 2015
revert emf model rebuild changes for layers view
|
It seems that way. When you have more then one map the provider references the first map when sending events. I did not dig too far into the code to figure out why this was occurring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To undo some changes made when the EMF model was regenerated. These changes caused the layer view to not update correctly. More info: https://locationtech.org/mhonarc/lists/udig-dev/msg24060.html