New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preference Page added for WMSService #220
Conversation
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nprigour Thanks for the ull request, just added two comments regarding translaton and "overwrite" defaults for installations.
public void initializeDefaultPreferences() { | ||
IPreferenceStore store = WmsPlugin.getDefault().getPreferenceStore(); | ||
|
||
store.setDefault(WmsPreferencePage.WMS_RESPONSE_TIMEOUT, 30); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we define a constant with a semantic to describe what "30" means, e.g. DEFAULT_WMS_RESPONSE_TIMEOUT_IN_SECONDS:
public static final int DEFAULT_WMS_RESPONSE_TIMEOUT_IN_SECONDS = 30;
In addition, is it possible to Start uDig with another default (overwrite in configuration) and how?
@nprigour Could you add a screenshout to docs and improve WMS Preferences page (content of http://udig.github.io/docs/user/reference/Preferences.html) or Catalog Preferences
@Override | ||
protected void createFieldEditors() { | ||
|
||
addField(new IntegerFieldEditor(WMS_RESPONSE_TIMEOUT, "WMS response timeout", getFieldEditorParent())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please externalize the string to properties files as well? So Users could translated it usin e.g. Transifex (https://www.transifex.com/udig/udig/dashboard/)
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
I have amended the pull request to address your comments regarding translation/internationalization and user documentation. |
@nprigour Overwrite is interesting for automatic deployment without giving the users a checklist with tasks to configure their instance. It was just an idea but I cannot find the link to the discussion we had on the mailing list Looks good to me, thanks again for your contribution! |
Added a dedicated Preference Page under the Catalog category from WMS Service which enables the configuration of a timeout value while waiting for a response. This option is needed since by default the blocking time was 30 sec which might not be enough when a large area is requested or the connection is slow.

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com