New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preference Page added for WMSService #220

Merged
merged 2 commits into from Mar 10, 2017

Conversation

Projects
None yet
2 participants
@nprigour
Contributor

nprigour commented Mar 9, 2017

Added a dedicated Preference Page under the Catalog category from WMS Service which enables the configuration of a timeout value while waiting for a response. This option is needed since by default the blocking time was 30 sec which might not be enough when a large area is requested or the connection is slow.
image

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

Preference Page added for WMSService
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@fgdrf

@nprigour Thanks for the ull request, just added two comments regarding translaton and "overwrite" defaults for installations.

public void initializeDefaultPreferences() {
IPreferenceStore store = WmsPlugin.getDefault().getPreferenceStore();
store.setDefault(WmsPreferencePage.WMS_RESPONSE_TIMEOUT, 30);

This comment has been minimized.

@fgdrf

fgdrf Mar 9, 2017

Contributor

can we define a constant with a semantic to describe what "30" means, e.g. DEFAULT_WMS_RESPONSE_TIMEOUT_IN_SECONDS:

public static final int DEFAULT_WMS_RESPONSE_TIMEOUT_IN_SECONDS = 30;

In addition, is it possible to Start uDig with another default (overwrite in configuration) and how?

@nprigour Could you add a screenshout to docs and improve WMS Preferences page (content of http://udig.github.io/docs/user/reference/Preferences.html) or Catalog Preferences

@Override
protected void createFieldEditors() {
addField(new IntegerFieldEditor(WMS_RESPONSE_TIMEOUT, "WMS response timeout", getFieldEditorParent()));

This comment has been minimized.

@fgdrf

fgdrf Mar 9, 2017

Contributor

Could you please externalize the string to properties files as well? So Users could translated it usin e.g. Transifex (https://www.transifex.com/udig/udig/dashboard/)

amendments required for internationalization and user documentation
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@nprigour

This comment has been minimized.

Contributor

nprigour commented Mar 10, 2017

I have amended the pull request to address your comments regarding translation/internationalization and user documentation.
Overwrite default value for WMS_RESPONSE_TIMEOUT is not possible (why do we need that really?). User can change this via the preference page if he experience problems obtaining the WMS response

@fgdrf fgdrf merged commit b63ebd4 into locationtech:master Mar 10, 2017

@fgdrf

This comment has been minimized.

Contributor

fgdrf commented Mar 10, 2017

@nprigour Overwrite is interesting for automatic deployment without giving the users a checklist with tasks to configure their instance. It was just an idea but I cannot find the link to the discussion we had on the mailing list

Looks good to me, thanks again for your contribution!

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Mar 10, 2017

@fgdrf fgdrf added the feature label Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment