Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix for duplicate legend entries for color ramp rasters #229

Merged
merged 1 commit into from May 28, 2017
Merged

minor fix for duplicate legend entries for color ramp rasters #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...g.locationtech.udig.legend/src/org/locationtech/udig/legend/ui/ColorMapLegendCreator.java
View file
Open in desktop
Expand Up @@ -205,7 +205,7 @@ public ImageData getImageData() {

String l1 = entry.getLabel();
String l2 = prevEntry.getLabel();
if (i <= entries.length - 3){
if (i < entries.length - 1){
Copy link
Contributor

@fgdrf fgdrf May 19, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egouge I'm not sure what this if-Statement is for because in the else-block the first inner statement (l2 == null) looks pretty identical to the inner statement of that if.

Question : What's the reason/use-case that String[] text can have length of 1 or the length of two? I thought that a LegendEntry represents one line in the Legend with ImageDescriptor and text element. My understanding is that every entry should have a LegentEntry representation after iterations. The if-Statement looks like only for the last one merge the text of the previous and the current and make a new Entry out of it. Why has the last Entry an array lenght for text of two while all others have a lenght of one. What I did not understand?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: What's the reason/use-case that String[] text can have length of 1 or the length of two?
A: From what I remember - it was the only way I could "easily" get "gradient" styles to appear in the correctly without substantially rewriting other parts of the Legend Graphic.
In the case shown above there are four labels (0, 3, 6, 8) but in terms of the colors (and legend entries) there are only three: white to light green [0-3]; light green to medium green [3-6]; and medium green to dark green [6,8]. So in order to get all the labels to show up one of those three legend entries needed to have two labels.
I am sure there were other ways of doing this, but this is what I came up with at the time.

if (l2 == null){
text = new String[]{q2};
}else{
Expand Down