Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve discovery of all geometry types during when adding a Mysql Host layer #232

Merged
merged 6 commits into from May 29, 2017

Conversation

@nprigour
Copy link
Contributor

@nprigour nprigour commented May 25, 2017

when adding a new Layer through the top level menu and selecting MySql Host as data source (Layer-->add -->MySql Host) after selection of the appropriate DB schema, only tables with a spatial column of generic Geometry are visible.
The provided pull request improves this by making visible also tables containing a spatial column of all possible geometry types ("point", "multipoint", "line", "linestring", "polygon", "multipolygon") so that they can be added to the CatalogView

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

nprigour added 2 commits May 25, 2017
layer

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
checking

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@nprigour
Copy link
Contributor Author

@nprigour nprigour commented May 25, 2017

Add attachement to explain improvement
pull_request232.pdf

@fgdrf
Copy link
Contributor

@fgdrf fgdrf commented May 28, 2017

Sounds very reasonable and patch looks quite good. 👍

It would be great to have the third screenshot (see attachment pull_request232.pdf) or something similiar on a new page in the docs down below http://udig.github.io/docs/user/tasks/Using%20the%20Catalog.html e.g. "Adding Features from MySQL"

@nprigour Can you help here either?

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@nprigour
Copy link
Contributor Author

@nprigour nprigour commented May 29, 2017

sphinx documentation updated

@fgdrf fgdrf added this to the uDig-2.0.0 milestone May 29, 2017
@fgdrf

This comment has been minimized.

I guess you mean the instead of they, aren't you?

@fgdrf

This comment has been minimized.

What do you think about using MySQL rather than Mysql everywhere (like in the header)?

fgdrf and others added 3 commits May 29, 2017
.. to avoid restart enumeration after image
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@fgdrf fgdrf merged commit e366032 into locationtech:master May 29, 2017
@fgdrf fgdrf added the improvement label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.