Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upimprove discovery of all geometry types during when adding a Mysql Host layer #232
Conversation
nprigour
added some commits
May 25, 2017
This comment has been minimized.
This comment has been minimized.
|
Add attachement to explain improvement |
This comment has been minimized.
This comment has been minimized.
|
Sounds very reasonable and patch looks quite good. It would be great to have the third screenshot (see attachment pull_request232.pdf) or something similiar on a new page in the docs down below http://udig.github.io/docs/user/tasks/Using%20the%20Catalog.html e.g. "Adding Features from MySQL" @nprigour Can you help here either? |
This comment has been minimized.
This comment has been minimized.
|
sphinx documentation updated |
fgdrf
added this to the
uDig-2.0.0 milestone
May 29, 2017
This comment has been minimized.
This comment has been minimized.
fgdrf
commented on docs/user/en/tasks/Adding features from MySQL.rst in 24b5877
May 29, 2017
|
I guess you mean the instead of they, aren't you? |
This comment has been minimized.
This comment has been minimized.
fgdrf
commented on docs/user/en/tasks/Adding features from MySQL.rst in 24b5877
May 29, 2017
|
What do you think about using MySQL rather than Mysql everywhere (like in the header)? |
fgdrf
and others
added some commits
May 29, 2017
fgdrf
merged commit e366032
into
locationtech:master
May 29, 2017
fgdrf
added
the
improvement
label
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nprigour commentedMay 25, 2017
when adding a new Layer through the top level menu and selecting MySql Host as data source (Layer-->add -->MySql Host) after selection of the appropriate DB schema, only tables with a spatial column of generic Geometry are visible.
The provided pull request improves this by making visible also tables containing a spatial column of all possible geometry types ("point", "multipoint", "line", "linestring", "polygon", "multipolygon") so that they can be added to the CatalogView
Signed-off-by: Nikolaos Pringouris nprigour@gmail.com