Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix problem causing deadlock while copying features between the same shapefile layer #261
Conversation
nprigour
referenced this pull request
Jan 7, 2018
Closed
Problem in shapefile saving when copying features from same layer #260
This comment has been minimized.
This comment has been minimized.
|
The present pull request seems to address also the following locationtech bug |
This comment has been minimized.
This comment has been minimized.
|
Thanks for providing this patch! Going to test copy & paste within the same layer today .. |
fgdrf
self-requested a review
Jan 9, 2018
fgdrf
added this to the
uDig-2.0.0 milestone
Jan 9, 2018
| @@ -285,7 +288,7 @@ private Query createQuery( ILayer sourceLayer, Filter filter, Layer targetLayer, | ||
| queryAttributes.putAll(FeatureUtils.createAttributeMapping(sourceSchema, targetSchema)); | ||
| Set<String> properties = new HashSet(queryAttributes.values()); | ||
| return new DefaultQuery(sourceSchema.getName().getLocalPart(), filter, properties | ||
| return new Query(sourceSchema.getName().getLocalPart(), filter, properties |
This comment has been minimized.
This comment has been minimized.
fgdrf
Jan 9, 2018
Contributor
It the switch from DefaultQuery to Query related to the bugfix or just a cleanup here?
This comment has been minimized.
This comment has been minimized.
nprigour
Jan 9, 2018
•
Contributor
Just cleanup since DefaultQuery has been marked as deprecated and synonymous to plain Query class
This comment has been minimized.
This comment has been minimized.
fgdrf
Jan 9, 2018
Contributor
Tested context menu in map panel with right mouse -> copy (of selected feature) and pased it on map
tested also to copy more than one feature
copy in map-panel and paste onto layer works as expected
Thanks again for fixing this issue!
fgdrf
merged commit acd64a3
into
locationtech:master
Jan 9, 2018
1 check passed
ip-validation
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nprigour commentedJan 7, 2018
fix for problem described in issue #260.
It seems that corresponding feature iterator was never closed for the copied feature collection and the maintained read locks caused problem when trying a write lock was attempted during commit time.
Signed-off-by: Nikolaos Pringouris nprigour@gmail.com