fix problem causing deadlock while copying features between the same shapefile layer #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same shapefile layer Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
|
The present pull request seems to address also the following locationtech bug |
|
Thanks for providing this patch! Going to test copy & paste within the same layer today .. |
fgdrf
reviewed
Jan 9, 2018
| @@ -285,7 +288,7 @@ private Query createQuery( ILayer sourceLayer, Filter filter, Layer targetLayer, | |||
|
|
|||
| queryAttributes.putAll(FeatureUtils.createAttributeMapping(sourceSchema, targetSchema)); | |||
| Set<String> properties = new HashSet(queryAttributes.values()); | |||
| return new DefaultQuery(sourceSchema.getName().getLocalPart(), filter, properties | |||
| return new Query(sourceSchema.getName().getLocalPart(), filter, properties | |||
There was a problem hiding this comment.
It the switch from DefaultQuery to Query related to the bugfix or just a cleanup here?
There was a problem hiding this comment.
Just cleanup since DefaultQuery has been marked as deprecated and synonymous to plain Query class
There was a problem hiding this comment.
Tested context menu in map panel with right mouse -> copy (of selected feature) and pased it on map ✔️
tested also to copy more than one feature ✔️
copy in map-panel and paste onto layer works as expected ✔️
Thanks again for fixing this issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for problem described in issue #260.
It seems that corresponding feature iterator was never closed for the copied feature collection and the maintained read locks caused problem when trying a write lock was attempted during commit time.
Signed-off-by: Nikolaos Pringouris nprigour@gmail.com