Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Feature Table view sorting and selection problems #293

Merged
merged 3 commits into from Sep 18, 2019

Conversation

nprigour
Copy link
Contributor

@nprigour nprigour commented Jun 28, 2018

fix for udig eclipse bug-536390 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=536390) related to TableView behavior during sorting and selection of rows

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

@fgdrf
Copy link
Contributor

fgdrf commented Jun 28, 2018

related but different issue in the same view : #246

@nprigour
Copy link
Contributor Author

Hi @fgdrf ,
Shall we also merge this? It is almost 10 months in open status and I do not see any further enhancement to it.

@fgdrf
Copy link
Contributor

fgdrf commented Sep 9, 2019

@nprigour Thanks for this reminder ;) Only thing I'd like you to dO : Please check formatter settings, because whole files are changed and the diff is hard to read. Had origin sources even wrong formattings?

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@nprigour
Copy link
Contributor Author

Rebased and forced pushed. Now the actual changes should be evident

@fgdrf fgdrf merged commit b0508b2 into locationtech:master Sep 18, 2019
fgdrf pushed a commit to fgdrf/udig-platform that referenced this pull request Dec 23, 2019
* fix Feature Table view sorting and selection
* fix initial ordering of FIDComparator
* added hashcode and equals methods to SelectionComparator

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants