Rollback issue #305
Merged
Rollback issue #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Sementsov <michael.sementsov@ibykus.de>
|
It would be great to have an unit test for this behavior, would you provide it? |
With timestamps, so you can check which command was executed first (and rolled back first). Signed-off-by: Michael Sementsov <michael.sementsov@ibykus.de>
|
Waiting for Jenkins feedback : https://ci.eclipse.org/udig/job/uDig-PR/31/ |
fgdrf
reviewed
Oct 23, 2018
...tiontech.udig.tool.edit.tests/src/org/locationtech/udig/tools/edit/BehaviourCommandTest.java
Show resolved
Hide resolved
fgdrf
pushed a commit
to fgdrf/udig-platform
that referenced
this pull request
Dec 23, 2019
* Rollback needs to be done in reverse order Signed-off-by: Michael Sementsov <michael.sementsov@ibykus.de> * Rollback test With timestamps, so you can check which command was executed first (and rolled back first). Signed-off-by: Michael Sementsov <michael.sementsov@ibykus.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BehaviorCommand: Commands need to be rolled back from last to first.
Signed-off-by: Michael Sementsov michael.sementsov@ibykus.de