get fill transparency of edit geom from preference store #313
Conversation
Signed-off-by: sloob <sebastian.loob@ibykus.de>
| @@ -116,6 +116,8 @@ EditToolPreferences_snapRadius = Snap Radius | |||
|
|
|||
| EditToolPreferences_vertexDiameter = Vertex Diameter | |||
|
|
|||
| EditToolPrefernece_fillTransparency = Reduce Fill Transparency (0-100) | |||
There was a problem hiding this comment.
Wondering if describes "Fill Transparency" what this preferences is about. In addition validation of min/max values of of inputField allows only valid inputs.
There was a problem hiding this comment.
Hi @fgdrf
a value of 0 means, that the fill of the edit geom is transparent. A value of 100 means, that there is no transparency. Maybe the right description is 'Geometry fill' or 'Opacity'?
There was a problem hiding this comment.
Good point, just had a look at Style Dialogs and I agree, we should have a consitent usage within uDig:
Let's use "Fill Opacity" for now and "Vertex Opacity" for #324
|
Thanks for this contribution and improvement! |
Signed-off-by: sloob <sebastian.loob@ibykus.de>
|
While submitting the other pull request I noticed a missmatch betwenn labeled "Opacity" and internal usage of variables "transparency". because #313 is submitted we have merge conflictes for this change. Can you please resolve these and rename variables and properties? Many Thanks! |
Signed-off-by: sloob <sebastian.loob@ibykus.de>
| @@ -116,7 +116,7 @@ EditToolPreferences_snapRadius = Snap Radius | |||
|
|
|||
| EditToolPreferences_vertexDiameter = Vertex Diameter | |||
|
|
|||
| EditToolPrefernece_fillTransparency = Reduce Fill Transparency (0-100) | |||
| EditToolPrefernece_fillTransparency = Fill Opacity | |||
There was a problem hiding this comment.
Would you refactor this property to EditToolPreferences_fillOpacity and update screenshot for EditTool Preferences page (doc).
There was a problem hiding this comment.
hi @fgdrf,
yes i can do that. I try to fix it this week.
There was a problem hiding this comment.
the last commit also fixes the misspelling variable for the vertex opacity, so i think #328 is not needed anymore
Signed-off-by: sloob <sebastian.loob@ibykus.de>
|
@sloob Again, many thanks for this improvement! |
* get fill opacity of edit geom from preference store Signed-off-by: sloob <sebastian.loob@ibykus.de>
Adds the possibility to specify the factor to reduce the transparency of the color used to fill the geoms on the EditBlackboard.
Signed-off-by: sloob sebastian.loob@ibykus.de