improve DistanceTool to work correctly during Map zoom in and zoom out actions #333
Conversation
actions and also display last segment length Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
|
Great, thanks for contributing. I'll test it and give you feedback. In between I triggered Jenkins to give feedback first : https://ci.eclipse.org/udig/job/uDig-PR/39/ |
|
The jenkins failure is irrelevant to the present PR. However I think we had this kind of failure in the past around one year ago and somehow it was resolved. Now it seems to appear again. Strange things! Did we change anything? |
| @@ -1,2 +1,2 @@ | |||
| DistanceTool_distance = Entfernung \= {0} | |||
| DistanceTool_distance = Entfernung \= {0} (letztes segment \= {1}) | |||
There was a problem hiding this comment.
What do you think about "Gesamtstrecke = {0} (aktuelles Segment = {1})"
There was a problem hiding this comment.
OK modification commited after all you are the German guy
...ech.udig.tool.measure/src/org/locationtech/udig/tool/measure/internal/messages_ru.properties
Outdated
Show resolved
Hide resolved
|
checked current docs and I guess the page is still valid : http://udig.github.io/docs/user/reference/Information%20Tools#distance-tool |
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
|
For the italian translation from the little I know we are OK. |
|
I'd prefer to remove properties files we not totally sure about translation. Would you remove all oher message files than messages.properties, messages_de.properties, and messages_it.properties (if you are sure about)? |
|
I'd like to suggest a little optimization. What do you think about switching the display of the last segement and total distance such as "Distance: {0} (total: {1})" and displaying the information directly at the cursor rather than in the Status bar: here is a little example:
I can create a pull request for your branch... |
|
Why not have them both? In any case you can proceed with the suggested PR in order to check behavior . By the way will you provide an indication of length for each segment as seen on map? |
Do you mean having a rendered label at cursur in Map and updted statusbar?
✔️ Done, its fine from my perspective and ready to merge except i18n ressources we should remove from this pull ;)
Yeah, forgot to mentioned it, every segment could get rendered a label as shown. However it might have conflicts to other labels of other segments. Could be optional .. |
|
Hi @fgdrf , Now I thought you will provide a PR on my existing PR branch. Isn't that the case? Do you want to proceed first with merging the present and you create a separate PR on the master branch?. If yes, please confirm and I will proceed with the removal of the i18n resources i order to conclude the PR. Now regarding the labelling in each segment indeed it may cause some clutter but in many cases will be very useful. May be you can control it by an appropriate preference option? |
|
@nprigour Sorry for confusion, lets proceed with this PR as it is and I'll create another with minor optimizations. It takes a bit longer :P For now, lets proceed with the removal of the i18n resources and we can merge this PR! Thanks in advance for fixing it! Preferences Option is a good point I'll address! |
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
|
OK remove i18n for es, eu, ru, ko country codes |
…t actions (locationtech#333) * improve DistanceTool to work correctly during Map zoom in and zoom out actions and also display last segment length Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
When pwrforming a zoom in or zoom out while using the DistanceTool the DistanceTool lines do not scale correctly (actually they do not scale at all) together with the map leading to weird results. This PR attempts to fix this by storing clicked points as coordinates and not points and performing the conversion during final rendering on screen.
Another enhancement introduced by this PR is that the displayed information at the bottom left of the screen includes also information about the last segment length.
Signed-off-by: Nikolaos Pringouris nprigour@gmail.com