Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message bubble display access fix #367

Merged
merged 2 commits into from Dec 31, 2019
Merged

Message bubble display access fix #367

merged 2 commits into from Dec 31, 2019

Conversation

fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Dec 25, 2019 •
edited

see origin commit 4b429b2 by @MSementsov-Ibk

Thanks for your contribution

@fgdrf fgdrf force-pushed the MessageBubble_display_access_fix branch from 7e1005b to 24a6bb8 Compare December 25, 2019 20:52
@fgdrf fgdrf mentioned this pull request Dec 25, 2019
Closed
MSementsov-Ibk and others added 2 commits December 31, 2019 10:54
@MSementsov-Ibk @fgdrf
Fixed Problems with this method if setGraphics was never called and t…
4b429b2 
…here was no run

Signed-off-by: Michael Sementsov <michael.sementsov@ibykus.de>
@fgdrf
safe-check for available ViewportPane (display)
aab9b38 
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
@fgdrf fgdrf force-pushed the MessageBubble_display_access_fix branch from 8304007 to aab9b38 Compare December 31, 2019 09:55
@fgdrf fgdrf added this to the 2.2.0 milestone Dec 31, 2019
@fgdrf fgdrf merged commit 63796be into locationtech:master Dec 31, 2019
@nprigour
Copy link
Contributor

nprigour commented Jan 1, 2020

Hi @fgdrf,

I cannot understand the relation of this one with #300. It does not seems to address the issue described there. Can you explain a bit?

@fgdrf
Copy link
Contributor Author

fgdrf commented Jan 1, 2020

@nprigour Wondering a bit and referenced orgin commit ;)

@fgdrf fgdrf deleted the MessageBubble_display_access_fix branch January 1, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgdrf @nprigour @MSementsov-Ibk