Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed variables in contact state #7

Merged
merged 3 commits into from May 12, 2021

Conversation

cmastalli
Copy link
Member

Unfortunately, the current version of the ContactState.msg does not follow a standard.
This modification breaks the API, as the old-stored messages won't be compatible.

Therefore, this modification will lead to a jump in the version.
@wxmerkt - I won't merge this PR until our packages are compatible.

Final note
If you have stored a rosbag with previous standard, then you will need to use v0.0.1.

@wxmerkt
Copy link
Contributor

wxmerkt commented May 10, 2021

Can we please also add migration rules in order to be able to update old log files (I have ~100 GB of logs from the MPC experiments so this can help in updating them)?

@cmastalli
Copy link
Member Author

Can we please also add migration rules in order to be able to update old log files (I have ~100 GB of logs from the MPC experiments so this can help in updating them)?

Oh, I didn't know about this possibility. I fully agree with you, just give sometime to figure out how to do it.

Thanks for the feedback :)

@wxmerkt
Copy link
Contributor

wxmerkt commented May 10, 2021

I'll start using this branch / the updated messages from today for experiments and will update the code where no PRs exist yet

@cmastalli
Copy link
Member Author

@wxmerkt -- let me know if this all we need!

@cmastalli
Copy link
Member Author

@wxmerkt -- it seems that it is not pulling the branch from my forked copy of the repository.

@wxmerkt
Copy link
Contributor

wxmerkt commented May 10, 2021

I would ignore the travis failure, will test locally ~tomorrow

@wxmerkt
Copy link
Contributor

wxmerkt commented May 11, 2021

I believe this works well - I can still parse old logs. We can go ahead with merging :-)

@cmastalli cmastalli merged commit 9ee1168 into loco-3d:master May 12, 2021
@cmastalli cmastalli deleted the topic/contact-state branch May 13, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants