Python2: always require a 44.x version of setuptools #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this with ROS prereleases of |
gavanderhoorn
changed the title
But not anything newer. Older versions don't appear to work reliably with `pip==20.1`. This helps when running a build of a package depending on catkin_virtualenv on OS which ship with an old version of setuptools (such as Ubuntu Xenial) when `USE_SYSTEM_PACKAGES` is not set to `FALSE`. In that situation, only specifying 'setuptools<45` will be true, as setuptools is installed (in the systems site packages), so pip will not upgrade it. Specifying a minimum version like this will force pip to always install an up-to-date version.
|
Prerelease test with Melodic on Bionic |
|
@paulbovbel: it's a bit ironic with 6 months+ of failing builds for my pkgs on the buildfarm, but could we get this merged so the build gets back to being green? ;) Provided this works for your use-cases as well of course. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version specification would also evaluate to true if
USE_SYSTEM_PACKAGESwasTRUEand the base OS already had a version ofsetuptoolsinstalled (which is often the case).On Xenial fi this leads to
20.7.0satisfying the<45requirement, but that version doesn't appear to be compatible withpip==20.1.For context, see #70.