Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New loss functions #142

Merged
merged 1 commit into from Feb 26, 2020
Merged

New loss functions #142

merged 1 commit into from Feb 26, 2020

Conversation

efernandez
Copy link
Collaborator

@efernandez efernandez commented Feb 13, 2020 •
edited

efernandez
efernandez commented Feb 13, 2020
View reviewed changes
Copy link
Collaborator Author

@efernandez efernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments to help with the review.

fuse_loss/include/fuse_loss/loss_function.h Show resolved Hide resolved
fuse_loss/include/fuse_loss/loss_function.h Outdated Show resolved Hide resolved
@efernandez efernandez mentioned this pull request Feb 13, 2020
Merged
@efernandez efernandez mentioned this pull request Feb 18, 2020
Merged
@efernandez
Copy link
Collaborator Author

Rebased --skip to resolve the conflicts now that #141 is in.

svwilliams
svwilliams reviewed Feb 24, 2020
View reviewed changes
fuse_loss/include/fuse_loss/loss_function.h Outdated Show resolved Hide resolved
fuse_loss/include/fuse_loss/loss_function.h Outdated Show resolved Hide resolved
fuse_loss/include/fuse_loss/loss_function.h Outdated Show resolved Hide resolved
fuse_loss/include/fuse_loss/loss_function.h Outdated Show resolved Hide resolved
fuse_loss/include/fuse_loss/welsch_loss.h Outdated Show resolved Hide resolved
fuse_loss/include/fuse_loss/fair_loss.h Outdated Show resolved Hide resolved
fuse_loss/include/fuse_loss/loss_function.h Outdated Show resolved Hide resolved
fuse_loss/src/loss_function.cpp Show resolved Hide resolved
@efernandez efernandez force-pushed the new_loss_functions branch 3 times, most recently from 46f10e7 to c99fce1 Compare February 24, 2020 14:44
@efernandez efernandez force-pushed the new_loss_functions branch 3 times, most recently from 2a9e496 to a7099d1 Compare February 26, 2020 10:31
@efernandez
Add new loss functions
81dee03 
The following loss functions, not available in Ceres solver are
provided:
* Geman-McClure
* DCS (Dynamic Covariance Scaling)
* Fair
* Pseudo-Huber
* Welsch
@svwilliams svwilliams merged commit 8c5ee65 into locusrobotics:devel Feb 26, 2020
@efernandez efernandez deleted the new_loss_functions branch March 11, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrton04 ayrton04 ayrton04 approved these changes

@svwilliams svwilliams svwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efernandez @ayrton04 @svwilliams