Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
latch
param tofalse
by default infuse_publishers::SerializedPublisher
.The motivation is the same one that is described in #183
If we want to record graph and transaction messages and play them back, we likely need to throttle recording the graph messages because it'd take too much disk and BW to record all.
Therefore, when playing things back, we don't want to have the throttled graph played back as latched, because then the node is ignited/started at time when the transaction that happened right after the graph was likely published too long ago.
Consider this example:
10.0s
t_b = 170.0
latch
ed topic, then it'd be publishedlatch
ed byrosbag play
. So we get the graph from timet_g < t_b
published, e.g.t_g = 165.0
.t_t >= t_b
, e.g.t_t = 170.1
, which is way after the graph.This means the transaction cannot be applied to the graph from
t_g
because it'd likely reference non-existent constraints or variables.I can certainly set the
latch
param tofalse
in my config, but it took me some time to figure this out, so I believe the default value should befalse
.