-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fuse_models::Transaction sensor model #195
Merged
svwilliams
merged 1 commit into
locusrobotics:devel
from
clearpathrobotics:transaction-sensor-model
Jun 3, 2020
Merged
Add fuse_models::Transaction sensor model #195
svwilliams
merged 1 commit into
locusrobotics:devel
from
clearpathrobotics:transaction-sensor-model
Jun 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d935e9
to
6da9c17
Compare
@svwilliams @ayrton04 Could you share with me the error from the checks that are failing, please? |
|
6ec0967
to
8a69948
Compare
Thanks. I forgot to close the plugin declaration with |
ayrton04
approved these changes
May 26, 2020
svwilliams
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to review this. Looks like you just need to rebase this, and I'll get it merged.
8a69948
to
b08ed47
Compare
b08ed47
to
f1b720d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuse_models::Transaction
sensor modelI'm going to send another PR with a
fuse_models::GraphIgnition
that complements this one and also adds a rostest. This should hopefully motivate #183 a bit more, although I understand the last comments there and they might actually be an issue. I still have to look at that.I'm open to other approaches to load a recorded graph and transactions.