Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuse_models::Transaction sensor model #195

Merged

Conversation

efernandez
Copy link
Collaborator

  • Add fuse_models::Transaction sensor model

I'm going to send another PR with a fuse_models::GraphIgnition that complements this one and also adds a rostest. This should hopefully motivate #183 a bit more, although I understand the last comments there and they might actually be an issue. I still have to look at that.

I'm open to other approaches to load a recorded graph and transactions.

@efernandez efernandez self-assigned this May 22, 2020
@efernandez efernandez added the enhancement New feature or request label May 22, 2020
@efernandez
Copy link
Collaborator Author

@svwilliams @ayrton04 Could you share with me the error from the checks that are failing, please?

@ayrton04
Copy link
Contributor

ayrton04 commented May 25, 2020

09:46:41  5: [fuse_optimizers.rosunit-FixedLagIgnition/SetInitialState][FAILURE]-------------
09:46:41  5: /home/ec2-user/workspace/test_rosdistro_fuse_PR-195/package/fuse_optimizers/test/test_fixed_lag_ignition.cpp:51
09:46:41  5: Value of: ros::service::waitForService("/fixed_lag/set_pose", ros::Duration(1.0))
09:46:41  5:   Actual: false
09:46:41  5: Expected: true
09:46:41  5: --------------------------------------------------------------------------------
09:46:37  3: [fuse_optimizers.rosunit-Optimizer/Constructor][FAILURE]------------------------
09:46:37  3: unknown file
09:46:37  3: C++ exception with description "According to the loaded plugin descriptions the class fuse_models::Unicycle2D with base class type fuse_core::MotionModel does not exist. Declared types are  fuse_locus::Unicycle2D" thrown in the test body.
09:46:37  3: --------------------------------------------------------------------------------

@efernandez efernandez force-pushed the transaction-sensor-model branch 2 times, most recently from 6ec0967 to 8a69948 Compare May 25, 2020 10:52
@efernandez
Copy link
Collaborator Author

Thanks. I forgot to close the plugin declaration with </class> 🤦

Copy link
Contributor

@svwilliams svwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to review this. Looks like you just need to rebase this, and I'll get it merged.

fuse_models/include/fuse_models/transaction.h Outdated Show resolved Hide resolved
@svwilliams svwilliams merged commit 1172343 into locusrobotics:devel Jun 3, 2020
@efernandez efernandez deleted the transaction-sensor-model branch June 10, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants