Add fuse_models::GraphIgnition sensor model #196
Conversation
efernandez
requested review from
svwilliams and
ayrton04
and removed request for
svwilliams
efernandez
force-pushed
the
graph-ignition-sensor-model
branch
4 times, most recently
from
291ec96
to
5eb8bdb
Compare
efernandez
force-pushed
the
graph-ignition-sensor-model
branch
from
5eb8bdb
to
0302cac
Compare
|
@ayrton04 @svwilliams Do you mind to also copy-paste here the check errors for this one, please? #195 Is passing now. Maybe this needs to be on top of it, but I don't think so. It could be another test failing, since I only made sure it compiles. Note that I moved both the Transaction and GraphIgnition sensor models from an internal repository, and I've already been using them w/o problems. I probably missed something else while moving things here. |
efernandez
force-pushed
the
graph-ignition-sensor-model
branch
from
0302cac
to
bdab0cf
Compare
| * @brief Compare all the properties of two Variable objects | ||
| * @return True if all the properties match, false otherwise | ||
| */ | ||
| bool compareVariables(const fuse_core::Variable& expected, const fuse_core::Variable& actual) |
There was a problem hiding this comment.
Maybe I'll make gtest macros for these one day. Thanks.
There was a problem hiding this comment.
I wonder if you'd create a header in fuse_core/include/fuse_core for that, or create a new fuse_test package for that. 🤔
I don't think we can access headers define in fuse_core/test, if we move them there. If we actually can, then that would be another option. Probably the best approach.
efernandez
force-pushed
the
graph-ignition-sensor-model
branch
from
bdab0cf
to
a94e5f3
Compare
|
The tests passed now. 🎉 So it looks like this is ready to merge. 😃 |
fuse_models::GraphIgnitionsensor modelThis complements #195, so we can configure a
fixed_lag_smootherthat ignites when it receives a recorded graph and then apply recorded transactions into it.This should help motivate #183 a bit more, and also help to test things out, if we agree on using these two sensor models to play back recorded graphs and transactions. This is certainly open to discussion, mostly because #183 is required, and it also looks that even with #183 there are still some sharp edges, so things don't always work because we don't process the correct transaction after the graph. Remember the intention is to throttle the graphs while recording, because recording all graphs takes a lot of disk and bandwidth.