Fixed compile error when using the latest version of rviz #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the latest melodic version of rviz (1.13.15), I get the following compile error:
The problem seems to be the forward declarations here:
https://github.com/locusrobotics/fuse/blob/devel/fuse_viz/include/fuse_viz/serialized_graph_display.h#L51-L57
But the header needs the full class definitions here:
https://github.com/locusrobotics/fuse/blob/devel/fuse_viz/include/fuse_viz/serialized_graph_display.h#L100
I suspect that the previous version of rviz was including the required headers somewhere, and this file was compiling due to this indirect include. Something in rviz subsequently changed, exposing the error here.
Technically I could leave the SceneNode as a forward declaration, as we only use a pointer to a SceneNode in this header. If that is preferred, or some other solution to this issue is desired, just let me know. I'm not exactly sure why there were forward declared to begin with.