Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rclcpp::Clock::wait_until_started #303

Merged

Conversation

sloretz
Copy link
Collaborator

@sloretz sloretz commented Dec 28, 2022

part of #276
Draft for now as this requires a new rolling release of rclcpp that includes ros2/rclcpp#2040

@svwilliams for visibility

@sloretz sloretz self-assigned this Dec 28, 2022
@sloretz
Copy link
Collaborator Author

sloretz commented Dec 29, 2022

Release of rclcpp made: ros/rosdistro#35711

@sloretz
Copy link
Collaborator Author

sloretz commented Dec 29, 2022

@ros-pull-request-builder retest this please

sloretz and others added 2 commits January 27, 2023 17:00
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@google.com>
@sloretz sloretz force-pushed the rolling-use-wait_until_started branch from 015c29e to 5ad0b19 Compare January 27, 2023 17:41
@sloretz sloretz marked this pull request as ready for review January 27, 2023 17:42
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
@sloretz
Copy link
Collaborator Author

sloretz commented Jan 27, 2023

Self review LGTM

Test failures are only linters in packages that haven't been linted yet

colcon test-result
build/fuse_models/Testing/20230127-1831/Test.xml: 12 tests, 0 errors, 4 failures, 0 skipped
build/fuse_models/test_results/fuse_models/copyright.xunit.xml: 48 tests, 0 errors, 2 failures, 0 skipped
build/fuse_models/test_results/fuse_models/cpplint.xunit.xml: 512 tests, 0 errors, 508 failures, 0 skipped
build/fuse_models/test_results/fuse_models/uncrustify.xunit.xml: 48 tests, 0 errors, 48 failures, 0 skipped
build/fuse_models/test_results/fuse_models/xmllint.xunit.xml: 2 tests, 0 errors, 1 failure, 0 skipped
build/fuse_optimizers/Testing/20230127-1831/Test.xml: 11 tests, 0 errors, 2 failures, 0 skipped
build/fuse_optimizers/test_results/fuse_optimizers/cpplint.xunit.xml: 266 tests, 0 errors, 266 failures, 0 skipped
build/fuse_optimizers/test_results/fuse_optimizers/uncrustify.xunit.xml: 17 tests, 0 errors, 17 failures, 0 skipped
build/fuse_tutorials/Testing/20230127-1831/Test.xml: 8 tests, 0 errors, 4 failures, 0 skipped
build/fuse_tutorials/test_results/fuse_tutorials/cpplint.xunit.xml: 94 tests, 0 errors, 94 failures, 0 skipped
build/fuse_tutorials/test_results/fuse_tutorials/flake8.xunit.xml: 6 tests, 0 errors, 6 failures, 0 skipped
build/fuse_tutorials/test_results/fuse_tutorials/uncrustify.xunit.xml: 8 tests, 0 errors, 8 failures, 0 skipped
build/fuse_tutorials/test_results/fuse_tutorials/xmllint.xunit.xml: 2 tests, 0 errors, 1 failure, 0 skipped

@methylDragon
Copy link
Collaborator

methylDragon commented Jan 28, 2023

I'm not sure why the RPr job is failing to find tf2_2d

It's in rosdistro https://github.com/ros/rosdistro/blob/dfb1574b597625fd0dcbe87b5d48a2a93c65eaf9/rolling/distribution.yaml#L5729

@sloretz
Copy link
Collaborator Author

sloretz commented Jan 28, 2023 via email

@methylDragon methylDragon merged commit ae9abfe into locusrobotics:rolling Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants