-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rclcpp::Clock::wait_until_started #303
Merged
methylDragon
merged 4 commits into
locusrobotics:rolling
from
sloretz:rolling-use-wait_until_started
Jan 28, 2023
Merged
Use rclcpp::Clock::wait_until_started #303
methylDragon
merged 4 commits into
locusrobotics:rolling
from
sloretz:rolling-use-wait_until_started
Jan 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release of rclcpp made: ros/rosdistro#35711 |
@ros-pull-request-builder retest this please |
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
force-pushed
the
rolling-use-wait_until_started
branch
from
January 27, 2023 17:41
015c29e
to
5ad0b19
Compare
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Self review LGTM Test failures are only linters in packages that haven't been linted yet
|
methylDragon
approved these changes
Jan 28, 2023
I'm not sure why the RPr job is failing to find tf2_2d It's in rosdistro https://github.com/ros/rosdistro/blob/dfb1574b597625fd0dcbe87b5d48a2a93c65eaf9/rolling/distribution.yaml#L5729 |
The PR job requires tf2_2d to be released into Rolling. Until that happens
we'll have to test locally.
…On Fri, Jan 27, 2023, 7:34 PM methylDragon ***@***.***> wrote:
I'm not sure why the RPr job is failing to find tf2_2d
—
Reply to this email directly, view it on GitHub
<#303 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA73OLSMPPWHC6BVA5RZAV3WUSHU5ANCNFSM6AAAAAATLUGS7U>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #276
Draft for now as this requires a new rolling release of rclcpp that includes ros2/rclcpp#2040
@svwilliams for visibility