Use getParameterName and namespace parameters for publishers #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
force-pushed
the
rolling-publishers-params
branch
from
4174227
to
13395be
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-publishers-params
branch
from
13395be
to
07aa2c9
Compare
54 tasks
sloretz
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #276
With the merge of #311, a new method was introduced to join parameter names together.
Also, it surfaced an inconsistency in how the publishers in fuse_publishers read their parameters. So I brought them in-line with the way SerializedPublisher was doing it following #311
In the ROS 1 code, private node handles were used to load the parameters, so by right they should be namespaced. This PR fixes that issue.
Pinging @svwilliams for visibility.