Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make runner / user count available to LoadTestShape #1719

Merged
merged 4 commits into from Mar 3, 2021

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Mar 1, 2021

Related to #1715

@msarahan
Copy link
Contributor Author

msarahan commented Mar 1, 2021

Here's a screenshot of running the example. The notable features are the plateaus at the 10, 20, and 10 user levels. We don't know what time it'll take to get there, but once we are there, we always sit there for the given pre-set time.

Screenshot from 2021-03-01 09-34-16

@cyberw
Copy link
Collaborator

cyberw commented Mar 1, 2021

Can you add a unit test?

@msarahan
Copy link
Contributor Author

msarahan commented Mar 1, 2021

I should probably also update the docs at https://docs.locust.io/en/latest/generating-custom-load-shape.html#generating-custom-load-shape to show this new function. I'll work on that a bit later.

@cyberw
Copy link
Collaborator

cyberw commented Mar 3, 2021

This looks good. Can you make runner a regular attribute (not _-prefixed). Maybe people will want to access some other attribute on the runner.

@cyberw cyberw merged commit fddfefe into locustio:master Mar 3, 2021
@cyberw
Copy link
Collaborator

cyberw commented Mar 3, 2021

nice!

@msarahan
Copy link
Contributor Author

msarahan commented Mar 3, 2021

Thanks for working with me on this. I'll close the other issue.

@msarahan msarahan deleted the wait_times branch March 3, 2021 15:59
@cyberw cyberw changed the title make user count available to LoadTestShape make runner / user count available to LoadTestShape Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants