make runner / user count available to LoadTestShape #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a screenshot of running the example. The notable features are the plateaus at the 10, 20, and 10 user levels. We don't know what time it'll take to get there, but once we are there, we always sit there for the given pre-set time.
|
|
Can you add a unit test? |
|
I should probably also update the docs at https://docs.locust.io/en/latest/generating-custom-load-shape.html#generating-custom-load-shape to show this new function. I'll work on that a bit later. |
|
This looks good. Can you make runner a regular attribute (not _-prefixed). Maybe people will want to access some other attribute on the runner. |
|
nice! |
|
Thanks for working with me on this. I'll close the other issue. |
cyberw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1715