fix: stopping state when running more than one worker node. #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Yes, the debug logging is a bit noisy :) (I wish we had a trace level though...) @mboutet LGTY? |
|
Could you have a look to see if it could be added as a test? |
Added a test. |
|
Nice! I'll give @mboutet a couple days to chime in, but it lgtm. |
|
LGTM also. If all tests are green, then it's good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the issue #2111 when running locust in distributed mode with more than 1 worker when the job is stopped the state is kept as STOPPING. Doing some investigation I realised after it removes a client from the list it gets back as a
readyone, thus when thecheck_stopped()is called it checks the state for all clients, as the operation is fast, before checking the second client the first one is alreadyreadyand pass theupdate_state(STATE_STOPPED)This PR intends to fix this bug hence to fix the continuously RPS in the graph even with the test "stopped" (issue with the graph shown bellow).