Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert url for getting tasks to relative #2121

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Convert url for getting tasks to relative #2121

merged 1 commit into from
Jun 23, 2022

Conversation

5imun
Copy link
Contributor

@5imun 5imun commented Jun 23, 2022

I was using Locust UI with kubernetes and after setting up ingress rule to expose the service on custom path I have noticed periodic 404 errors in the browser console occurring each second.

This happens because when using urls with absolute path that starts with / custom base path used for exposing the service in ingress rules gets lost so instead of 200 http://domain.com/locust/tasks we get 404 http://domain.com/tasks.
This change will make it relative so that base path /locust in example before will be preserved.

This is also related to issues #149, #2030 and PR 692 that solved this problem for code before 30 May 2018.
This will also solve issue #2071 reported by @benispeti

@cyberw cyberw merged commit 481e066 into locustio:master Jun 23, 2022
@cyberw
Copy link
Collaborator

cyberw commented Jun 23, 2022

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants