rAF as default for debounce/throtte (#3560) #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an additional option to debounce and throttle if `useRAF` is `true` and `requestAnimationFrame` is available on the `root` object, it will be used for timing instead of `setTimeout()`. This allows for very smooth and performant throttling of rapid firing events like scroll, resize, etc.
Uses `requestAnimationFrame` by default (when available on the `root` object), unless `wait` is specified.
|
|
|
Thanks for picking the up @mattlubner |
|
Thank you @jacob-beltran and @mattlubner! |
This was referenced Apr 19, 2018
|
This doesn't seem to be available in any release at the moment (checked in 4.17.10). Should it be? |
|
Hi @joshbuckley182! The 4.17.10 bump was just for Node 10 compatibility feature work won't show up until v5. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
requestAnimationFrameby default (when available on therootobject), unlesswaitis passed as0or a truthy value.This is in reply to #3562, and in turn, #3560.
Feedback is welcome and appreciated. 😀