Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant error checks #1120

Conversation

furkansenharputlu
Copy link

@furkansenharputlu furkansenharputlu commented Jun 12, 2024

This PR removes the repeating redundant error checks:

err := someFunc()
if err != nil {
   return err
} 

return nil

Instead, directly returning removes redundancy and makes code more readable like this:

return someFunc()

@furkansenharputlu
Copy link
Author

This is very disrespectful. There is a contribution. Even you don’t merge, you write a comment why you closed.

@pascal-breuninger
Copy link

Hey @furkansenharputlu, you’re right, sorry!
While we value the time you spent on the pr, it adds more noise than value in my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants