Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: nolog in general config #640 #815

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

mattiacapitanio
Copy link
Contributor

Added the feature to exclude the log events depending on the regular expression provided in the configuration.
The feature works in a similar way to the categoryFilter and logLevelFilter appenders. The log events, which will match the regular expression, will be excluded and not passed to the appender.
The regular expressions can be configured through a string or an array of strings.
The log events will be evaluated in case-insensitive mode.

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #815 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   97.48%   97.52%   +0.04%     
==========================================
  Files          24       25       +1     
  Lines         914      930      +16     
==========================================
+ Hits          891      907      +16     
  Misses         23       23
Impacted Files Coverage Δ
lib/appenders/noLogFilter.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7eee87...80ca596. Read the comment docs.

@nomiddlename nomiddlename added this to the 4.0.0 milestone Dec 2, 2018
@nomiddlename
Copy link
Collaborator

This looks good - thanks for the high quality contribution. I'll merge it into master, but it won't get released to NPM until I've finished the changes needed for #684 (amongst others) in version 4.0.0

@nomiddlename nomiddlename merged commit d0915bf into log4js-node:master Dec 2, 2018
@mattiacapitanio
Copy link
Contributor Author

Great! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants