Remove member variable as it's only used in the constructor

refs idaholab#17710
loganharbour · Nov 18, 2021 · be7ce39 · be7ce39
1 parent dc4427c
commit be7ce39
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/framework/include/meshgenerators/RenameBlockGenerator.h b/framework/include/meshgenerators/RenameBlockGenerator.h
@@ -39,6 +39,4 @@ class RenameBlockGenerator : public MeshGenerator
   std::vector<SubdomainName> _new_block;
   /// The name of the parameter that specifies the old blocks
   std::string _old_block_param_name;
-  /// The name of the parameter that specifies the new blocks
-  std::string _new_block_param_name;
 };
diff --git a/framework/src/meshgenerators/RenameBlockGenerator.C b/framework/src/meshgenerators/RenameBlockGenerator.C
@@ -105,6 +105,7 @@ RenameBlockGenerator::RenameBlockGenerator(const InputParameters & parameters)
     _old_block_param_name = "old_block_name";
   }
 
+  std::string new_block_param_name;
   if (isParamValid("new_block"))
   {
     if (isParamValid("new_block_id"))
@@ -116,22 +117,22 @@ RenameBlockGenerator::RenameBlockGenerator(const InputParameters & parameters)
                  "Cannot use with 'new_block'. Use only 'new_block'; 'new_block_name' is "
                  "deprecated.");
     _new_block = getParam<std::vector<SubdomainName>>("new_block");
-    _new_block_param_name = "new_block";
+    new_block_param_name = "new_block";
   }
   else if (isParamValid("new_block_id"))
   {
     for (const auto id : getParam<std::vector<SubdomainID>>("new_block_id"))
       _new_block.push_back(std::to_string(id));
-    _new_block_param_name = "new_block_id";
+    new_block_param_name = "new_block_id";
   }
   else
   {
     _new_block = getParam<std::vector<SubdomainName>>("new_block_name");
-    _new_block_param_name = "new_block_name";
+    new_block_param_name = "new_block_name";
   }
 
   if (_old_block.size() != _new_block.size())
-    paramError(_new_block_param_name, "Must be the same length as '", _old_block_param_name, "'");
+    paramError(new_block_param_name, "Must be the same length as '", _old_block_param_name, "'");
 }
 
 std::unique_ptr<MeshBase>