Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up single group value after unmount closes #3963 #3972

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Conversation

logaretm
Copy link
Owner

What

Fixes an issue where values of group fields with non-array value like radio inputs are not cleaned up on unmount

closes #3963

@codecov-commenter
Copy link

Codecov Report

Merging #3972 (900573d) into main (a4603fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3972   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          68       68           
  Lines        2006     2009    +3     
  Branches      515      517    +2     
=======================================
+ Hits         1924     1927    +3     
  Misses         82       82           
Impacted Files Coverage Δ
packages/vee-validate/src/useForm.ts 98.40% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@logaretm logaretm merged commit 8ccfd2b into main Oct 23, 2022
@logaretm logaretm deleted the fix/3963 branch October 23, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V4] The value of radio fields is kept by the form even when hidden
2 participants